Open
Conversation
strip-comments.js
Outdated
|
|
||
| var CommentStripper = function () { | ||
|
|
||
| var CommentStripper = function (options) { |
Owner
There was a problem hiding this comment.
I don't love the options object, especially when there's only one option. i'd prefer either just have preserveNewLines as public, or getter and setter methods for it. of course the readme would need to be updated as well
…h a setter function
…e' in node.js Would you adopt those changes into your repository? And could you also make this available via 'npm install'? You would also have to create a package.json file. Of course I can do this as well, but because it's originally your code and it's maintained in your repo, I would think it's more appropriate if the npm package is also connected to you...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you don't mind I would also like to wrap a module.exports around it (thus we could easily make an npm compatible package of it).